Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport][Admin] Made configurable product variations table cell label hidden #21691

Merged
merged 1 commit into from
Mar 14, 2019
Merged

[Backport][Admin] Made configurable product variations table cell label hidden #21691

merged 1 commit into from
Mar 14, 2019

Conversation

eduard13
Copy link
Contributor

Original PR #20528

Description (*)

Made configurable product variations table body cell label hidden, because they were positioned (absolute) all in on place above the table.

Fixed Issues (if relevant)

  1. [Admin] Configurable product variations table cell labels wrong position #20527: Configurable product variations table cell labels wrong position
  2. ...

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@eduard13 eduard13 requested a review from dmytro-ch March 11, 2019 14:43
@ghost ghost unassigned dmytro-ch Mar 11, 2019
@ghost
Copy link

ghost commented Mar 11, 2019

@eduard13 unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@magento-engcom-team magento-engcom-team added Component: ConfigurableProduct Release Line: 2.2 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 11, 2019
@dmytro-ch dmytro-ch self-assigned this Mar 11, 2019
@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21691.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4470 has been created to process this Pull Request

@soleksii soleksii self-assigned this Mar 12, 2019
@soleksii
Copy link

✔️ QA Passed

@p-bystritsky p-bystritsky self-assigned this Mar 12, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 14, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit adf4425 into magento:2.2-develop Mar 14, 2019
@ghost
Copy link

ghost commented Mar 14, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 14, 2019
@sidolov
ENGCOM-4470: [Backport][Admin] Made configurable product variations t…
dd1b43d 
…able cell label hidden #21691
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@dmytro-ch dmytro-ch

@p-bystritsky p-bystritsky

@soleksii soleksii

Labels
Component: ConfigurableProduct Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.9
Development

Successfully merging this pull request may close these issues.
5 participants
@eduard13 @magento-engcom-team @dmytro-ch @soleksii @p-bystritsky